Add command to add JDK to settings #4162
Merged
+87
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
reviewed
Sep 26, 2025
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Seems mostly fine. Just be aware this overlaps with https://github.com/microsoft/vscode-java-pack/blob/main/src/java-runtime/index.ts and it probably would have been ideal to move that page here.
fbricon
requested changes
Oct 9, 2025
Collaborator
fbricon
left a comment
fbricon
left a comment
There was a problem hiding this comment.
Can you please rebase against the main branch? JavaSE-25 is available now.
src/javaRuntimes.ts
Outdated
| if (config.some(r => r.path === directory[0].fsPath)) { | ||
| vscode.window.showErrorMessage(`JDK Directory ${directory[0].fsPath} already configured`); | ||
| } else { | ||
| const name = await vscode.window.showQuickPick(getSupportedJreNames(), { |
Collaborator
There was a problem hiding this comment.
I would improve it by:
- detecting the java version of the selected path
- preselect the matching execution environment name
- filter out incompatible environments, i.e don't show JavaSE-22 and above if you selected a JDK 21.
Collaborator
There was a problem hiding this comment.
also pre Java 8 support has been dropped over a year ago. Can you remove the J2SE-1.5 ... JavaSE-7 values in package.json
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
4161_add_jdk_command
branch
from
3c9b691 to
cbe1b37
Compare
fbricon
requested changes
Nov 7, 2025
src/javaRuntimes.ts
Outdated
| if (runtime) { | ||
| const config = vscode.workspace.getConfiguration('java.configuration').get('runtimes'); | ||
| if (Array.isArray(config)) { | ||
| const candidates = getSupportedJreNames().filter(name => !config.some(r => r.name === name) && compatible(runtime, name)); |
Collaborator
There was a problem hiding this comment.
- I would not prevent overriding existing JRE Mappings, e.g. I want to switch from one JDK 11.0.0 to 11.0.1
- versions should be sorted by most recent version 1st
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Collaborator
|
Thanks @tsmaeder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a VS Code command that
Fixes #4161